Added check for template file #197

kadern0 · 2020-03-02T09:52:30Z

Description

Added check to verify template file exists, if not, an informative message is printed.

Fixes #194

How Has This Been Tested?

Run the test from project's root directory:

./bin/ofc-bootstrap create-github-app --root-domain test
Name: OFC elegant leavitt5	Root domain: test	Scheme: https
Launching browser: http://127.0.0.1:30010
Starting local HTTP server on port 30010
Please complete the workflow in the browser to create your GitHub App.
^C

Run the test from outside:

kaderno@kaderno-XPS-13-9360:~/go/src/github.com$ ./ofc-bootstrap/bin/ofc-bootstrap create-github-app --root-domain test
Error: Cannot find the template file. You need to run this command from the root directory of the repository.

Checklist:

I have:

checked my changes follow the style of the existing code / OpenFaaS repos
updated the documentation and/or roadmap in README.md
read the CONTRIBUTION guide
signed-off my commits with git commit -s
added unit tests

derek · 2020-03-02T09:52:34Z

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

Waterdrips

LGTM

alexellis

Just a small change please

alexellis · 2020-03-03T16:04:42Z

cmd/create_github.go

@@ -64,6 +65,11 @@ func createGitHubAppE(command *cobra.Command, _ []string) error {
 		"GitHubEvent": fmt.Sprintf("%s://system.%s/github-event", scheme, rootDomain),
 	}

+	_, err := os.Stat(path.Join("./pkg/github", "index.html"))


Please can you inline this? if _, err :=

alexellis · 2020-03-03T16:05:23Z

Nice work 😁

alexellis · 2020-03-04T09:20:09Z

cmd/create_github.go

@@ -64,6 +65,10 @@ func createGitHubAppE(command *cobra.Command, _ []string) error {
 		"GitHubEvent": fmt.Sprintf("%s://system.%s/github-event", scheme, rootDomain),
 	}

+	if _, err := os.Stat(path.Join("./pkg/github", "index.html")); err != nil {
+		return fmt.Errorf("Cannot find the template file. You need to run this command from the root directory of the repository.\n ")


Just so that you know, errors in Go cannot start with an uppercase letter or end with a .

Can I suggest this alternative? -> cannot find template "index.html", run this command from the ofc-bootstrap repository

alexellis

One more change, again, just stylistic about how Go projects are usually written.

alexellis · 2020-03-04T09:21:57Z

cmd/create_github.go

@@ -64,6 +65,10 @@ func createGitHubAppE(command *cobra.Command, _ []string) error {
 		"GitHubEvent": fmt.Sprintf("%s://system.%s/github-event", scheme, rootDomain),
 	}

+	if _, err := os.Stat(path.Join("./pkg/github", "index.html")); err != nil {


Spot on 👍

alexellis

I think you need to use ``` backticks for the outer string did this compile ok?

alexellis · 2020-03-04T10:34:35Z

You need to build locally before pushing. This is causing a syntax error. Please remove the newline too.


`some "string" goes here`

Signed-off-by: kadern0 <kaderno@gmail.com>

kadern0 · 2020-03-04T10:46:43Z

That happens when you copy and paste without looking :( my bad!

alexellis

Looks perfect. Hope the feedback was useful? Will merge when CI passes

derek bot added new-contributor no-dco labels Mar 2, 2020

kadern0 force-pushed the issue-194 branch from e0a5f58 to 80be496 Compare March 2, 2020 09:54

derek bot removed the no-dco label Mar 2, 2020

Waterdrips approved these changes Mar 3, 2020

View reviewed changes

alexellis suggested changes Mar 3, 2020

View reviewed changes

kadern0 force-pushed the issue-194 branch 2 times, most recently from be72124 to f7fb0d7 Compare March 4, 2020 07:51

alexellis reviewed Mar 4, 2020

View reviewed changes

alexellis suggested changes Mar 4, 2020

View reviewed changes

alexellis reviewed Mar 4, 2020

View reviewed changes

kadern0 force-pushed the issue-194 branch from f7fb0d7 to 70d396d Compare March 4, 2020 09:35

alexellis reviewed Mar 4, 2020

View reviewed changes

Added check for template file

16f9fe4

Signed-off-by: kadern0 <kaderno@gmail.com>

kadern0 force-pushed the issue-194 branch from 70d396d to 16f9fe4 Compare March 4, 2020 10:44

alexellis approved these changes Mar 4, 2020

View reviewed changes

alexellis merged commit 19a7220 into openfaas:master Mar 6, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added check for template file #197

Added check for template file #197

kadern0 commented Mar 2, 2020

derek bot commented Mar 2, 2020

Waterdrips left a comment

alexellis left a comment

alexellis Mar 3, 2020

alexellis commented Mar 3, 2020

alexellis Mar 4, 2020

alexellis Mar 4, 2020

alexellis left a comment

alexellis Mar 4, 2020

alexellis left a comment

alexellis commented Mar 4, 2020

kadern0 commented Mar 4, 2020

alexellis left a comment

Added check for template file #197

Added check for template file #197

Conversation

kadern0 commented Mar 2, 2020

Description

How Has This Been Tested?

Checklist:

derek bot commented Mar 2, 2020

Waterdrips left a comment

Choose a reason for hiding this comment

alexellis left a comment

Choose a reason for hiding this comment

alexellis Mar 3, 2020

Choose a reason for hiding this comment

alexellis commented Mar 3, 2020

alexellis Mar 4, 2020

Choose a reason for hiding this comment

alexellis Mar 4, 2020

Choose a reason for hiding this comment

alexellis left a comment

Choose a reason for hiding this comment

alexellis Mar 4, 2020

Choose a reason for hiding this comment

alexellis left a comment

Choose a reason for hiding this comment

alexellis commented Mar 4, 2020

kadern0 commented Mar 4, 2020

alexellis left a comment

Choose a reason for hiding this comment