Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 2019-06-13-introducing-openfaas-for-lambda.md #242

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mt-kelvintaywl
Copy link

@mt-kelvintaywl mt-kelvintaywl commented Jun 25, 2021

I just noticed a tiny typo in the naming of AWS ECR service; hope this was the correct intention.

Description

Motivation and Context

Have you applied the editorial and style guide to your post?

See the README.md

How have you tested the instructions for any tutorial steps?

Types of changes

  • New blog post
  • Updating an existing blog post
  • Updating part of the page page
  • Adding a new web-page

Checklist:

  • I have given attribution for any images I have used and have permission to use them under Copyright law
  • My code follows the writing-style of the publication and I have checked this
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s

@derek
Copy link

derek bot commented Jun 25, 2021

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

@derek derek bot added the no-dco label Jun 25, 2021
@alexellis
Copy link
Member

Thanks for finding the typo.

Would you like to run the commands that the bot is asking you to, or do you want us to update it instead?

I just noticed a tiny typo in the naming of AWS ECR service; hope this was the correct intention.

Signed-off-by: Kelvin <ktay@moneytree.jp>
@mt-kelvintaywl
Copy link
Author

@alexellis updated with the suggested commands from the bot indeed :) thank you!

@alexellis
Copy link
Member

@welteki please can you check if we still need this PR or whether we made the change already? Then I'll merge or close accordingly.

@welteki
Copy link
Member

welteki commented Jun 17, 2022

We did not make these changes yet.

@rgee0
Copy link
Contributor

rgee0 commented Nov 2, 2024

The noted error remains within this post. This PR content is still valid for merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants