Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ruby version to 2.7.2 #14

Merged
merged 2 commits into from
Jan 6, 2021
Merged

Update ruby version to 2.7.2 #14

merged 2 commits into from
Jan 6, 2021

Conversation

blijblijblij
Copy link
Contributor

As proposed in #13, I have also taken the liberty to include a newer version of the of-watchdog

@derek
Copy link

derek bot commented Jan 6, 2021

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

Signed-off-by: Rogier <rogier@blijblijblij.com>
Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Thank you for the PR

@alexellis
Copy link
Member

Just one more thing is required, since we have no CI on this repo yet.

Please show some evidence of testing (console output is sufficient) - including with and without a gem.

@blijblijblij
Copy link
Contributor Author

Just one more thing is required, since we have no CI on this repo yet.

Please show some evidence of testing (console output is sufficient) - including with and without a gem.

Here is the regular one running on my homecluster (k3s / rpi4 / ubuntu arm64)

Forking - ruby [index.rb]
2021/01/06 11:24:42 Started logging stderr from function.
2021/01/06 11:24:42 Started logging stdout from function.
2021/01/06 11:24:42 OperationalMode: http
2021/01/06 11:24:42 Timeouts: read: 10s, write: 10s hard: 10s.
2021/01/06 11:24:42 Listening on port: 8080
2021/01/06 11:24:42 Writing lock-file to: /tmp/.lock
2021/01/06 11:24:42 Metrics listening on port: 8081
2021/01/06 11:24:43 stderr: [2021-01-06 11:24:43] INFO  WEBrick 1.6.0
2021/01/06 11:24:43 stderr: [2021-01-06 11:24:43] INFO  ruby 2.7.2 (2020-10-01) [aarch64-linux]
2021/01/06 11:24:43 stderr: == Sinatra (v2.1.0) has taken the stage on 5000 for development with backup from WEBrick
2021/01/06 11:24:43 stderr: [2021-01-06 11:24:43] INFO  WEBrick::HTTPServer#start: pid=16 port=5000
2021/01/06 11:25:14 stderr: 10.42.0.164 - - [06/Jan/2021:11:25:14 +0000] "GET / HTTP/1.1" 200 60 0.0149
2021/01/06 11:25:14 GET / - 200 OK - ContentLength: 60
2021/01/06 11:25:14 stderr: 127.0.0.1 - - [06/Jan/2021:11:25:14 UTC] "GET / HTTP/1.1" 200 60
2021/01/06 11:25:14 stderr: - -> /

Now with the added logging gem which adds some more logging.info:

Forking - ruby [index.rb]
2021/01/06 12:31:14 Started logging stderr from function.
2021/01/06 12:31:14 Started logging stdout from function.
2021/01/06 12:31:14 OperationalMode: http
2021/01/06 12:31:14 Timeouts: read: 10s, write: 10s hard: 10s.
2021/01/06 12:31:14 Listening on port: 8080
2021/01/06 12:31:14 Writing lock-file to: /tmp/.lock
2021/01/06 12:31:14 Metrics listening on port: 8081
2021/01/06 12:31:15 stderr: [2021-01-06 12:31:15] INFO  WEBrick 1.6.0
2021/01/06 12:31:15 stderr: [2021-01-06 12:31:15] INFO  ruby 2.7.2 (2020-10-01) [aarch64-linux]
2021/01/06 12:31:15 stderr: == Sinatra (v2.1.0) has taken the stage on 5000 for development with backup from WEBrick
2021/01/06 12:31:15 stderr: [2021-01-06 12:31:15] INFO  WEBrick::HTTPServer#start: pid=14 port=5000
2021/01/06 12:31:54 stdout: I, [2021-01-06T12:31:54.643631 #14]  INFO : #############################
2021/01/06 12:31:54 stdout: I, [2021-01-06T12:31:54.643811 #14]  INFO : Some logging from the installed logging gem
2021/01/06 12:31:54 stdout: I, [2021-01-06T12:31:54.643880 #14]  INFO : #############################
2021/01/06 12:31:54 stderr: 10.42.0.164 - - [06/Jan/2021:12:31:54 +0000] "GET / HTTP/1.1" 200 62 0.0290
2021/01/06 12:31:54 GET / - 200 OK - ContentLength: 62
2021/01/06 12:31:54 stderr: 127.0.0.1 - - [06/Jan/2021:12:31:54 UTC] "GET / HTTP/1.1" 200 62
2021/01/06 12:31:54 stderr: - -> /

@alexellis
Copy link
Member

It's my fault for not having the issue template in this repo.

Maybe that could be PR #2 to copy it in from https://github.com/openfaas/templates?

@alexellis alexellis merged commit e730d69 into openfaas:master Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants