-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ruby version to 2.7.2 #14
Conversation
Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide. |
Signed-off-by: Rogier <rogier@blijblijblij.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. Thank you for the PR
Just one more thing is required, since we have no CI on this repo yet. Please show some evidence of testing (console output is sufficient) - including with and without a gem. |
Here is the regular one running on my homecluster (k3s / rpi4 / ubuntu arm64)
Now with the added
|
It's my fault for not having the issue template in this repo. Maybe that could be PR #2 to copy it in from https://github.com/openfaas/templates? |
As proposed in #13, I have also taken the liberty to include a newer version of the
of-watchdog