Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the repo to the template pull command #8

Merged

Conversation

koffeinfrei
Copy link
Contributor

@koffeinfrei koffeinfrei commented Oct 6, 2019

The README for the faas template pull command is currently missing the repository url.

Signed-off-by: Alexis Reigel <mail@koffeinfrei.org>
@derek derek bot added new-contributor invalid This doesn't seem right labels Oct 6, 2019
@derek
Copy link

derek bot commented Oct 6, 2019

Thank you for your contribution. I've just checked and your Pull Request doesn't appear to have any description.
That's something we need before your Pull Request can be merged. Please see our contributing guide.

@alexellis alexellis merged commit 5be7639 into openfaas:master Oct 14, 2019
@alexellis
Copy link
Member

/remove label: invalid

@derek derek bot removed the invalid This doesn't seem right label Oct 14, 2019
@alexellis
Copy link
Member

Thanks for adding the description to the PR, I see Derek picked up on that.

Do make time to read the contributing guide, all contributors are expected to use it.

@koffeinfrei koffeinfrei deleted the fix/readme-pull-from-repository branch October 14, 2019 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants