Remove Java8 and arm-based templates #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users are still using the java8 template despite java8 being deprecated. This should prevent that going forward, the java11 template is compatible. Users can use an older SHA / tag of the repo if they are still migrating off the deprecated java8 template: https://github.com/openfaas/templates/releases/tag/1.9.0 The armhf and arm64 templates are no longer required, since they are duplicates of the normal templates. What matters more for arm is using a multi-arch template, or building on the correct device. There's no explicit need to use the armhf template as it adds nothing. Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alex Ellis (OpenFaaS Ltd) alexellis2@gmail.com
Description
Remove Java8 and arm-based templates
Motivation and Context
Users are still using the java8 template despite java8 being
deprecated. This should prevent that going forward, the java11
template is compatible.
Users can use an older SHA / tag of the repo if they are still
migrating off the deprecated java8 template:
https://github.com/openfaas/templates/releases/tag/1.9.0
The armhf and arm64 templates are no longer required, since
they are duplicates of the normal templates. What matters more
for arm is using a multi-arch template, or building on the
correct device. There's no explicit need to use the armhf
template as it adds nothing.
Types of changes
Impact to existing users
Users of armhf templates can simply remove the suffix in their stack.yml file and build with the non-armhf templates on their devices.
java8 users should migrate with immediate effect, or use the older release tag mentioned above when setting up their templates repo.