Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options verb to node12 template #222

Merged
merged 1 commit into from
Oct 14, 2020
Merged

Conversation

jebos
Copy link
Contributor

@jebos jebos commented Oct 14, 2020

Fix issue #220

@derek
Copy link

derek bot commented Oct 14, 2020

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

…handler.js can implement custom response behavior

Signed-off-by: Jeremias Bosch <jeremias.bosch@basyskom.com>
Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

For future reference, please see our commit guidelines so that your title doesn't wrap multiple lines, and you explain testing / or why it's needed in the commit as well as the PR.

@alexellis alexellis merged commit 3b4f9eb into openfaas:master Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants