Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shikachuu zcmate@gmail.com
Description
To mostly maintain backward compatibility I update the images to PHP 7.4 to keep the
php7
name.Update PHP version everywhere to 7.4, changed composer flag to
:1
to always use the most up-to-datecomposer:1
version.(I also added type hints to the
Handler
class, but that's not the main topic of this pull request, so it can be removed if there is a need.)Motivation and Context
The reason behind this PR is that PHP 7.2 is EOL since 2020 November and composer was way down in security patches.
Which issue(s) this PR fixes
How Has This Been Tested?
Since it is just a version bump in the Dockerfile I just ran a Docker build command to check for complications.
Types of changes
Impact to existing users
Checklist:
git commit -s