fix: install faas-cli as a seperate CI step #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run faas-cli install in it's own step to because this will install it into the users PATH for us and the setup/verify script will intelligently skip the faas-cli install step. This avoids a bug where the script assumes that the cli was installed into the tmp dir instead of the PATH. Signed-off-by: Lucas Roesler <roesler.lucas@gmail.com>
|
Thank you for the quick fix @LucasRoesler |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Run faas-cli install in it's own step to because this will install it
into the users PATH for us and the setup/verify script will
intelligently skip the faas-cli install step. This avoids a bug where
the script assumes that the cli was installed into the tmp dir instead
of the PATH.
Apparently, the runner now has enough permissions to do this, but it couldn't before.
Motivation and Context
None, this was requested in Slack
Which issue(s) this PR fixes
NA
How Has This Been Tested?
The CI flow passed correctly in my fork.
Types of changes
Impact to existing users
None, this just fixes the CI process
Checklist:
git commit -s