-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(import): add progress bar for store import #348
Conversation
Minder Vulnerability Report ✅Minder analyzed this PR and found no vulnerable dependencies.
|
Here is how it would look: (Added custom time sleep to record demo) Screen.Recording.2024-06-14.at.6.04.59.PM.mov |
Finally, the lints are passing now (in my fork -- ref). Checks on this PR needs to be approved by collaborators. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Siddhant-K-code ! This is awesome!
Because we don't do squash merging on the CLI, may I ask you to squash your commits into the first one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome PR @Siddhant-K-code! I've just some comments about an issue arise during importing a new store and flickering of the progress bar
The linter seems to have some awkward output with the lints being flagged occurring before that output (lines 31-36), output is below, I think we might be able to have the action annotate with these but will need to check it out
|
I pushed the lint fixes and squashed the commits down |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for another awesome contribution @Siddhant-K-code! ❤️
We're going to file some follow on issues here such as mirroring this into fga tuple write
but we're going to land and release this before that.
Description
This pull request adds a progress bar to the store import feature. Previously, the import process did not provide any visual feedback to the user, making it difficult to determine the progress. With this change, a progress bar is displayed, indicating the number of tuples being imported. This improves the user experience and provides better visibility into the import process.
See video below in slow-mode (or test with super long file) :
Screen.Recording.2024-06-14.at.4.58.03.PM.mov
How to test
Open this PR in Gitpod (it would automatically run the required commands to install deps.) or in local.
Add a
demo.fga.yaml
file undercmd/fga
Under
cmd/fga
directory run the following command:Demo file
References
fixes #320
Review Checklist
main