Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: DSL should not allow schema version not specified #127

Merged
merged 1 commit into from
Apr 3, 2023
Merged

fix: DSL should not allow schema version not specified #127

merged 1 commit into from
Apr 3, 2023

Conversation

adriantam
Copy link
Member

@adriantam adriantam commented Mar 31, 2023 •
edited
Loading

Description

If the model schema is not defined in DSL, we should not assume it is 1.0

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@adriantam adriantam requested a review from a team as a code owner March 31, 2023 23:01
@adriantam adriantam merged commit 5ecf5c3 into main Apr 3, 2023
@adriantam adriantam deleted the fix/enforce_schema_version branch April 3, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamzeh rhamzeh rhamzeh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adriantam @rhamzeh