Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(utils): update schema version for modular models #273

Merged
merged 1 commit into from
Aug 23, 2024
Merged

feat(utils): update schema version for modular models #273

merged 1 commit into from
Aug 23, 2024

Conversation

ttrzeng
Copy link
Contributor

@ttrzeng ttrzeng commented Aug 19, 2024 •
edited
Loading

Description

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@ttrzeng ttrzeng requested review from a team as code owners August 19, 2024 16:12
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Aug 19, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: ttrzeng / name: Talent Zeng (c15ddcb)

@ttrzeng ttrzeng requested a review from ewanharris August 19, 2024 16:16
rhamzeh
rhamzeh previously approved these changes Aug 19, 2024
View reviewed changes
@rhamzeh rhamzeh mentioned this pull request Aug 19, 2024
Merged
4 tasks
rhamzeh
rhamzeh reviewed Aug 19, 2024
View reviewed changes
Copy link
Member

@rhamzeh rhamzeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also squash all the commits into one and force push?

See for more on squashing commits:

src/tools/monaco/providers/completion.ts Show resolved Hide resolved
@ttrzeng ttrzeng closed this Aug 19, 2024
@ttrzeng ttrzeng force-pushed the update-schema-versioning branch from 9b58e5a to c1e3c3b Compare August 19, 2024 17:55
@rhamzeh rhamzeh reopened this Aug 19, 2024
@rhamzeh rhamzeh force-pushed the update-schema-versioning branch 2 times, most recently from f1dafef to ed2011a Compare August 21, 2024 02:28
@ttrzeng ttrzeng force-pushed the update-schema-versioning branch from ed2011a to 35647a9 Compare August 22, 2024 16:48
ewanharris
ewanharris previously approved these changes Aug 22, 2024
View reviewed changes
@ttrzeng ttrzeng force-pushed the update-schema-versioning branch 2 times, most recently from d11c1a5 to 46f1bf8 Compare August 22, 2024 17:15
@rhamzeh rhamzeh force-pushed the update-schema-versioning branch from 46f1bf8 to 71625a0 Compare August 23, 2024 18:21
@rhamzeh rhamzeh force-pushed the update-schema-versioning branch from 71625a0 to c15ddcb Compare August 23, 2024 18:23
@rhamzeh rhamzeh enabled auto-merge August 23, 2024 18:24
@rhamzeh rhamzeh added this pull request to the merge queue Aug 23, 2024
Merged via the queue into main with commit b4f3029 Aug 23, 2024
21 checks passed
@rhamzeh rhamzeh deleted the update-schema-versioning branch August 23, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamzeh rhamzeh rhamzeh left review comments

@ewanharris ewanharris ewanharris approved these changes

@jimmyjames jimmyjames jimmyjames approved these changes

@evansims evansims Awaiting requested review from evansims

@d-jeffery d-jeffery Awaiting requested review from d-jeffery

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ttrzeng @jimmyjames @rhamzeh @ewanharris