Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix needs for create-release and pass tag name via env #54

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

ewanharris
Copy link
Member

Description

Just needed to rename the needs field to publish, restructured also so the workflow reads like how it runs.

Also moving to pass via env makes it safer to read from context to avoid injection attacks.

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

Passing via env makes it safer to read from context to avoid injection attacks
@ewanharris ewanharris requested review from a team as code owners September 9, 2024 17:30
@rhamzeh rhamzeh merged commit a67c7f9 into main Sep 9, 2024
14 checks passed
@rhamzeh rhamzeh deleted the ci/fix-release branch September 9, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants