Skip to content

Commit

Permalink
remove redundant test
Browse files Browse the repository at this point in the history
  • Loading branch information
jimmyjames committed Sep 23, 2024
1 parent 58438ec commit 1f7a00e
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 22 deletions.
20 changes: 0 additions & 20 deletions tests/index.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -272,26 +272,6 @@ describe("OpenFGA SDK", function () {
})
).toThrow();
});

it("should only accept valid telemetry metrics", async () => {

expect(
() =>
new OpenFgaApi({
...baseConfig,
telemetry: {
metrics: {
histogramRequestDuration: {
attributes: new Set<TelemetryAttribute>
},
counterCredentialsRequest: {
attributes: ["JUNK"] as any
},
}
}
})
).toThrow();
});
});

describe("error handling", () => {
Expand Down
2 changes: 0 additions & 2 deletions tests/telemetry/configuration.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,4 @@ describe("TelemetryConfiguration", () => {
])));
expect(config.metrics.histogramRequestDuration?.attributes).toEqual(TelemetryConfiguration.defaultAttributes);
});

// TODO verify behavior for only specifying some of the metrics, what should the others be set to?
});

0 comments on commit 1f7a00e

Please sign in to comment.