Add a unit to every legislative parameter

[benjello]

• Minor change.
• Impacted periods: all.
• Impacted areas: parameters
• Details:
  • Add a unit to every parameter

[benjello]

Related to openfisca/openfisca-core#681 and openfisca/openfisca-france#1022

[fpagnoux]

Why not EUR or USD instead of currency? These would be proper "units", while currency is more vague

[bonjourmauko]

Another option would be to namespace it : currency/EUR.

What do you think @fpagnoux @benjello ?

[fpagnoux]

Great minds think alike 😅 openfisca/openfisca-france#1022 (comment)

[fpagnoux]

The downside of using / though is that it can be confused with a division. We would have for instance EUR/m2 and currency/EUR where / has a totally different meaning. I guess we could use currency:EUR instead 🤔

[benjello]

One problem though is that the currency can change over time FRF vs EUR. Ans yes de have all the IR in France since 1917 !

[fpagnoux]

One problem though is that the currency can change over time FRF vs EUR. Ans yes de have all the IR in France since 1917 !

I think @michelbl knew about that when he designed the YAML format, and made sure unit could be specified at the value level.

So you could have something like:

description: montant des AF
unit: currency:EUR
values:
  2015-01-01: 
      value: 200
  ...
  2002-01-01: 
    value: 1000
    unit: currency:FRF
  2001-01-01:
    value: 950
    unit: currency:FRF

[benjello]

@fpagnoux ok then. But it maight be more diffuclt to deal with the code base of France as in here openfisca/openfisca-france#1022 so I suggest that we accept a raw currency too.

[fpagnoux]

@fpagnoux ok then. But it maight be more diffuclt to deal with the code base of France as in here openfisca/openfisca-france#1022 so I suggest that we accept a raw currency too.

It's a free-text property, so we'll accept everything :).

The discussion seems to have reached consensus, closing in favor of #49