Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: broken build #57

Merged
merged 10 commits into from
Sep 30, 2024
Merged

fix: broken build #57

merged 10 commits into from
Sep 30, 2024

Conversation

bonjourmauko
Copy link
Member

Fixes #56

  • Crash fix
  • Details:
    • Add pyproject.toml
    • Fix variables not being loaded
    • Upgrade country-template to latest

These changes:

  • Change non-functional parts of this repository (for instance editing the README)

@bonjourmauko bonjourmauko added the kind:fix A bug fix label Sep 29, 2024
@bonjourmauko bonjourmauko requested review from a team September 29, 2024 20:48
@bonjourmauko bonjourmauko self-assigned this Sep 29, 2024
@bonjourmauko bonjourmauko force-pushed the fix/broken branch 2 times, most recently from 25f9a84 to 5ec1246 Compare September 29, 2024 21:15
benjello
benjello requested changes Sep 30, 2024
View reviewed changes
openfisca_extension_template/variables/local_benefit.py Outdated
period: an `Instant` to calculate the variable.
parameters: a bounded function to query for model's parameters.
params: a bounded function to query for model's parameters.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be parameters here

openfisca_extension_template/variables/local_benefit.py Outdated Show resolved Hide resolved
bonjourmauko and others added 4 commits September 30, 2024 15:43
@bonjourmauko
chore: remove types from local_benefit.py
08b401b
@bonjourmauko
docs: fix params
a21dbbb
@bonjourmauko
style(lint): fix
efb344d
@bonjourmauko
chore: version bump
2e148b4 
Fixes #56

* Crash fix
* Details:
  - Add pyproject.toml
  - Fix variables not being loaded
  - Upgrade country-template to latest
@bonjourmauko bonjourmauko merged commit c2cd78d into master Sep 30, 2024
7 checks passed
@bonjourmauko bonjourmauko deleted the fix/broken branch September 30, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjello benjello benjello approved these changes

Assignees

@bonjourmauko bonjourmauko

Labels
kind:fix A bug fix
Projects
OpenFisca International
Status: Shipped
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build seems broken since country-template v6
2 participants
@bonjourmauko @benjello