Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Python 3.8 #1035

Closed
MaxGhenis opened this issue Aug 24, 2021 · 8 comments
Closed

Test Python 3.8 #1035

MaxGhenis opened this issue Aug 24, 2021 · 8 comments
Labels
kind:build Pull requests that update a dependency file

Comments

@MaxGhenis
Copy link
Contributor

Python 3.10 will also be launched in about 6 weeks.

@MattiSG
Copy link
Member

MattiSG commented Aug 24, 2021

Thanks @MaxGhenis!

Once #1030 is approved, we should have enough test runners to apply a matrix strategy that should let us test on several Python versions at once 😃

In order to help prioritise and avoid resource wastage, could you please share any deployment constraints you have / know of? With which version of Python do you currently use OpenFisca? 🙂

@bonjourmauko bonjourmauko added the kind:build Pull requests that update a dependency file label Aug 30, 2021
@bonjourmauko
Copy link
Member

I've been tinkering with a working prototype here #1031 😃 (it works in local if you want to try it out).

@MaxGhenis
Copy link
Contributor Author

In order to help prioritise and avoid resource wastage, could you please share any deployment constraints you have / know of?

No constraints, though there could be general performance improvements. @nikhilwoodruff also mentioned code structuring improvements in 3.9.

With which version of Python do you currently use OpenFisca?

3.7

@MattiSG
Copy link
Member

MattiSG commented Sep 3, 2021

#1030 has been approved, a preliminary implementation in openfisca/openfisca-france#1663 seems to show that 3.7 and 3.8 pass tests, while 3.9 fails at least for the Web API.

@bonjourmauko
Copy link
Member

@MattiSG great! In #1031 I've got all the tests passing for 3.9 but test_shell_script_with_reform, we can take a look together @HAEKADI if you think it could help.

@HAEKADI
Copy link
Contributor

HAEKADI commented Sep 6, 2021

@maukoquiroga The api-test keeps running without exiting for Python 3.9. You can take a look at the logs on GitHub Actions. I had to stop the workflow manually 🤔

@bonjourmauko bonjourmauko added this to the Improved testing milestone Sep 29, 2021
@MaxGhenis MaxGhenis changed the title Test Python 3.8 and 3.9 Test Python 3.8 Feb 22, 2022
@MaxGhenis
Copy link
Contributor Author

Since Python 3.9 has issues (#1035 (comment)), I shrunk this issue down to Python 3.8. Python 3.8 support would be especially useful since it's the default conda Python version, and that's how many developers install Python.

@bonjourmauko
Copy link
Member

This has been fixed in #1181

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:build Pull requests that update a dependency file
Projects
None yet
4 participants