Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider Core-provided Web API as stable #663

Closed
MattiSG opened this issue May 18, 2018 · 3 comments
Closed

Consider Core-provided Web API as stable #663

MattiSG opened this issue May 18, 2018 · 3 comments
Assignees
@MattiSG @fpagnoux
Milestone
v24

Comments

@MattiSG
Copy link
Member

MattiSG commented May 18, 2018

Since https://github.com/openfisca/openfisca-web-api is considered deprecated (see openfisca/openfisca-doc#140), there is no point in keeping the version number of the current web API at 0.1.0, nor in naming it “preview” anymore.
@MattiSG MattiSG self-assigned this May 18, 2018
MattiSG added a commit that referenced this issue May 18, 2018
@MattiSG
Consider Core-provided Web API as stable
2876bd5 
Fixes #663
@MattiSG MattiSG mentioned this issue May 30, 2018
Closed
@fpagnoux
Copy link
Member

Where did you see the 0.1.0 version number?

The whole point of the preview suffix was to avoid a conflict with the legacy API. Since it's now entirely deprecated, 👍 to rename the package.

@MattiSG
Copy link
Member Author

MattiSG commented May 31, 2018

Where did you see the 0.1.0 version number?

See related commit in work branch: 2876bd5#diff-23fa28715f5fb76e7d3e6d61bee8a92bL5

@fpagnoux fpagnoux self-assigned this Jun 27, 2018
@bonjourmauko
Copy link
Member

So I finally understand why it is called preview!

@fpagnoux fpagnoux added this to the v24 milestone Jul 24, 2018
@fpagnoux fpagnoux mentioned this issue Aug 2, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MattiSG MattiSG

@fpagnoux fpagnoux

Labels
None yet
Projects
None yet
Milestone
v24
Development

No branches or pull requests
3 participants
@MattiSG @bonjourmauko @fpagnoux