Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test collection #1075

Merged
merged 7 commits into from
Oct 26, 2021
Merged

Fix test collection #1075

merged 7 commits into from
Oct 26, 2021

Conversation

bonjourmauko
Copy link
Member

Fixes #1074
Relates to #1073

Bug fix

  • Fix the collection of OpenFisca-Core tests
    • Tests within openfisca_core/* were not being run

@bonjourmauko bonjourmauko added the kind:fix Bugs are defects and failure demand. label Oct 26, 2021
@bonjourmauko bonjourmauko requested review from MattiSG, benjello, sandcha and a team October 26, 2021 19:43
MattiSG
MattiSG requested changes Oct 26, 2021
View reviewed changes
Copy link
Member

@MattiSG MattiSG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @maukoquiroga!

I am not sure I understand if this only gathers more coverage data or actually runs more tests 🤔 Could you clarify this a bit more? 🙂

openfisca_tasks/test_code.mk Outdated Show resolved Hide resolved
setup.py Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@bonjourmauko
Copy link
Member Author

I am not sure I understand if this only gathers more coverage data or actually runs more tests 🤔 Could you clarify this a bit more? 🙂

Both!

This:

  1. Fixes the coverage data collection mechanism
  2. Runs the tests that should be run (by removing duplication in collection, which was the source of the bug)

I discovered 2. thanks to 1.

MattiSG
MattiSG approved these changes Oct 26, 2021
View reviewed changes
Copy link
Member

@MattiSG MattiSG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please check my last comments here though, they might make minor presentation adjustments that don't need an additional review 🙂

Thanks for this super quick fix! 👏

openfisca_tasks/test_code.mk Outdated Show resolved Hide resolved
Mauko Quiroga and others added 7 commits October 26, 2021 23:56
@bonjourmauko bonjourmauko merged commit 71847d0 into master Oct 26, 2021
@bonjourmauko bonjourmauko deleted the fix-coverage branch October 26, 2021 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattiSG MattiSG MattiSG approved these changes

@benjello benjello Awaiting requested review from benjello

@sandcha sandcha Awaiting requested review from sandcha

Assignees
No one assigned
Labels
kind:fix Bugs are defects and failure demand.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Coverage data collection is broken
2 participants
@bonjourmauko @MattiSG