Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove calls to deprecated imp module #1090

Merged
merged 2 commits into from
Dec 29, 2021
Merged

Remove calls to deprecated imp module #1090

merged 2 commits into from
Dec 29, 2021

Conversation

benjello
Copy link
Member

@benjello benjello commented Dec 2, 2021

Technical changes

I successfully ran make test locally.

Reopening #1087 cause of merge commit

@coveralls
Copy link

coveralls commented Dec 2, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.009%) to 78.885% when pulling c3bd472 on issue1053 into 601a397 on master.

@benjello benjello mentioned this pull request Dec 2, 2021
Closed
@sandcha sandcha changed the title Apply @maukoquiroga's suggested fix to #1053 Remove calls to deprecated imp module Dec 2, 2021
@MaxGhenis
Copy link
Contributor

Looks like this just needs a version bump?

@benjello benjello requested a review from MaxGhenis December 15, 2021 06:33
@MaxGhenis
Copy link
Contributor

@MattiSG @maukoquiroga @sandcha could you please review?

@benjello
Copy link
Member Author

Or @eraviart ?

eraviart
eraviart approved these changes Dec 29, 2021
View reviewed changes
Copy link
Member

@eraviart eraviart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be a canonical way to replace find_module & load_module using importlib (cf https://bugs.python.org/issue43540)

@benjello benjello merged commit 9deaa60 into master Dec 29, 2021
@benjello benjello deleted the issue1053 branch December 29, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxGhenis MaxGhenis MaxGhenis approved these changes

@eraviart eraviart eraviart approved these changes

@bonjourmauko bonjourmauko Awaiting requested review from bonjourmauko

@sandcha sandcha Awaiting requested review from sandcha

@MattiSG MattiSG Awaiting requested review from MattiSG

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DeprecationWarning for imp module in tax_benefit_system.py
4 participants
@benjello @coveralls @MaxGhenis @eraviart