Remove base attribute from ParameterScaleBracket #1162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
MattiSG
reviewed
Nov 23, 2022
|
Too late to finally know what it did? I always thought it was some sort of bit wise feature. |
|
@maukoquiroga : some french social security contribution (AGIRC-ARRCO, IRCANTEC, CSG, CRDS) have a theoretical rate and an actual rate with a corrective coefficient. We used base to host the latter to stick to the "law of unique source of truth". But not systematically, resulting in more confusion than convenience. So I prefer to remove it completely to force people follow the rule "explicit is better than implicit". |
benjello
force-pushed
the
remove-taxscale-bracket-base
branch
from
537cfeb to
2b1650e
Compare
|
@maukoquiroga : argh test fails after the bump ... |
|
This was failing because of incompatible caches. Now just because its a major, requires #1160 |
bonjourmauko
force-pushed
the
remove-taxscale-bracket-base
branch
from
d2f0a27 to
8132ab0
Compare
bonjourmauko
approved these changes
Nov 27, 2022
bonjourmauko
force-pushed
the
remove-taxscale-bracket-base
branch
from
bfd010b to
26c37c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1160
Breaking changes
This attribute is unclear and was used only for some French social security contributions