Introduce simulation generators #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anna-Livia
requested changes
Jan 4, 2018
tests/core/simulation_generator.py
Outdated
| adults = [0] + sorted(random.sample(xrange(1, nb_persons), nb_groups - 1)) | ||
|
|
||
| members_entity_id = np.empty(nb_persons, dtype = int) | ||
| members_legacy_role = np.empty(nb_persons, dtype = int) |
There was a problem hiding this comment.
Would it be helpful to write a reminder of the legacy_role indexes ?
There was a problem hiding this comment.
Added a comment to explain what legacy roles are
tests/core/simulation_generator.py
Outdated
|
|
||
| def make_simulation(tax_benefit_system, nb_persons, nb_groups, **kwargs): | ||
| """ | ||
| Generate a simulation containing nb_persons persons spread in nb_groups groups |
There was a problem hiding this comment.
Would an example (or a link to one) would be useful for fist time users ?
tests/core/simulation_generator.py
Outdated
|
|
||
| def randomly_init_variable(simulation, variable_name, period, max_value, condition = None): | ||
| """ | ||
| Initialise a variable with random values (from 0 to max_value) for the given period. |
There was a problem hiding this comment.
Would an example (or a link to one) would be useful for fist time users ?
|
As for the directory, would openfisca_core/tools/script be more appropriate ? |
fpagnoux
force-pushed
the
simulation-generator
branch
2 times, most recently
from
7b31f87 to
c761e48
Compare
fpagnoux
force-pushed
the
simulation-generator
branch
from
c761e48 to
daa52b6
Compare
fpagnoux
force-pushed
the
simulation-generator
branch
from
a9261b9 to
37b310a
Compare
Anna-Livia
approved these changes
Feb 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a helper function to generate arbitrarily big populations.
I used it a lot to investigate performances, and it could be reused. I put in in tests, but there may be a better spot.
This is clearly low priority