Add run test options #610
Add run test options #610
Conversation
|
Submitting this PR on the behalf of @bfabre01 which didn't have the right to push brances here and got confused on the different core branches. These are convenient options when you test for particular variables on a more complete test like the one produced by the openfisca/DGFiP comparator used for examples in this branch. |
|
@Anna-Livia @sandcha @fpagnoux : any chance you can have a look at this soon ? |
fpagnoux
force-pushed
the
add-run-test-options
branch
from
028cfd5 to
a5f408e
Compare
There was a problem hiding this comment.
Seems good to me, sorry for the delay.
@benjello two changes compared to the suggested implementation:
- The options have been renamed to be more explicit.
- No error message when using
--only-variablesfor a variable that is not tested in the file
Let me know if this is ok for you.
I rebased the branch on master, but @Anna-Livia @sandcha you may want to squash the commits before merging 🙂 .
CHANGELOG.md
Outdated
| @@ -1,5 +1,9 @@ | |||
| # Changelog | |||
|
|
|||
| ## 21.2.2 | |||
|
|
|||
| Add `--only` and `--ignore` options to `openfisca-run-test` to filter out tested output variables if needed. | |||
There was a problem hiding this comment.
--only seems a little too general. -n also only tests with the given name_filter in their name. What about --only-variables and --ignore-variables ?
openfisca_core/tools/test_runner.py
Outdated
| if output_variables is not None: | ||
| try: | ||
| if test_only is not None: | ||
| for variable in test_only: | ||
| assert variable in output_variables.keys(), "La variable {} n'est pas présente dans les outputs variables du test".format(variable) |
There was a problem hiding this comment.
Any reason to throw an error in that case ? It seems limitating : I cannot run all the rsa tests in mes-aides for instance, as an error would be raised for files that don't test rsa.
There was a problem hiding this comment.
@bfabre01 @ClaireLeroyIPP :
- should we raise an error to force the user to be sure to list the right tests to test his specific variable ?
- should we ignore tests when the variable is not present (my favorite) ?
|
@fpagnoux : c'est bon ! |
fpagnoux
force-pushed
the
add-run-test-options
branch
from
a5f408e to
3931aea
Compare
Thanks for contributing to OpenFisca! Remove this line, as well as any other in the following that don't fit your contribution :)
New features
--onlyand '--ignore` to openfisca-run-test