Make package compatible with Python 3 #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anna-Livia
reviewed
May 14, 2018
openfisca_core/parameters.py
Outdated
| return "ParameterAtInstant({})".format({self.instant_str: self.value}).encode('utf-8') | ||
| result = "ParameterAtInstant({})".format({self.instant_str: self.value}) | ||
| # repr output must be encoded in Python 2, but not in Python 3 | ||
| if sys.version_info < (3, 0): |
There was a problem hiding this comment.
Could this be a to_utf8 function ?It seem to happen several times in the code
There was a problem hiding this comment.
In both Python 2 and 3, __repr__ must return a str. But str has a different meaning in Python 2 and 3 😒: it is a byte in Python 2, but a unicode in Python 3.
We only want to encode the string in UTF-8 in Python 2, as in Python 3 we want to return a unicode. So if if we extracted the function, that would be to_utf8_if_python2, which doesn't seem great.
If all this encoding business is not clear for you, as it was for me a few days ago, I'd recommend this article[FR]. I can't pretend I understand everything now, but it's more clear 🙂.
Anna-Livia
approved these changes
May 14, 2018
|
👏 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once this is merged, we will also need to automatically publish python 3 versions of our packages on pypi.