Deploy package both in Python 2 and Python 3 #671
Conversation
| command: | | ||
| pip install --upgrade pip twine wheel | ||
| pip install --editable .[test] --upgrade | ||
| # pip install --editable git+https://github.com/openfisca/country-template.git@BRANCH_NAME#egg=OpenFisca-Country-Template # use a specific branch of OpenFisca-Country-Template |
There was a problem hiding this comment.
OpenFisca Country Template is a test dependency of Core. This line allows you to run the tests with a specific branch of the country template.
This is useful when working and breaking changes that imply editions both on core and country template.
| # . /tmp/venv/openfisca-core/bin/activate | ||
| # pip install --editable git+https://github.com/openfisca/country-template.git@BRANCH_NAME#egg=OpenFisca-Country-Template | ||
| pip install --editable .[test] --upgrade | ||
| # pip install --editable git+https://github.com/openfisca/country-template.git@BRANCH_NAME#egg=OpenFisca-Country-Template # use a specific branch of OpenFisca-Country-Template |
.circleci/config.yml
Outdated
| # PYPI_PASSWORD: this value is set in CircleCI's web interface; do not set it here, it is a secret! | ||
| - image: python:3.6 | ||
| environment: | ||
| PYPI_USERNAME: openfisca-bot # Edit this value to replace it by your Pypi username |
There was a problem hiding this comment.
This comment does not make sense in Core.
CHANGELOG.md
Outdated
| @@ -1,5 +1,9 @@ | |||
| # Changelog | |||
|
|
|||
| ### 23.1.2 [#671](https://github.com/openfisca/openfisca-core/pull/671) | |||
|
|
|||
| - Publish both Python 2 and Python 3 version on Pypi | |||
There was a problem hiding this comment.
Use the long, proper version changelog: Technical improvement etc. As a reuser not knowing about CI, this is mystifying, help me figure out I don't have to feel concerned!
There was a problem hiding this comment.
I don't think we ever agreed on a taxonomy of changesets in Core. What would not be a technical improvement?
There was a problem hiding this comment.
Happy to give more details about the consequences of the change though.
There was a problem hiding this comment.
Oh sorry, I reviewed too quickly 😞
|
Does this supersede #666? |
|
Seems good! I'll update required tests. |
|
Done! |
bonjourmauko
added
kind:feat
Applies consensus reached on Country Template to Core.
Supersedes #666