Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to set uncached variables when using a memory_config #687

Merged
merged 3 commits into from
Jul 11, 2018
Merged

Allow to set uncached variables when using a memory_config #687

merged 3 commits into from
Jul 11, 2018

Conversation

fpagnoux
Copy link
Member

@fpagnoux fpagnoux commented Jul 11, 2018 •
edited
Loading

Fixes #676

  • Allow to set uncached variables when using a memory_config
    • Previously, trying to set variables listed in variables_to_drop of the memory_config had no effect.
    • Now this variables are still not cached, but they can be set by the user.

@fpagnoux fpagnoux changed the title Allow to set uncached variables when using a memory_config Allow to set uncached variables when using a memory_config Jul 11, 2018
@fpagnoux fpagnoux force-pushed the allow-set-input-variable-not-cached branch from c273771 to 5d30d28 Compare July 11, 2018 03:34
@fpagnoux fpagnoux mentioned this pull request Jul 11, 2018
Closed
benjello
benjello approved these changes Jul 11, 2018
View reviewed changes
Copy link
Member

@benjello benjello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (but I might be not to more qualified for the review).
But it does the job: thanks !

@fpagnoux fpagnoux merged commit 8fff6dc into master Jul 11, 2018
@fpagnoux fpagnoux deleted the allow-set-input-variable-not-cached branch July 11, 2018 22:32
@bonjourmauko bonjourmauko added the kind:feat A feature request, a feature deprecation label Jul 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjello benjello benjello approved these changes

@sandcha sandcha Awaiting requested review from sandcha

@Anna-Livia Anna-Livia Awaiting requested review from Anna-Livia

Assignees
No one assigned
Labels
kind:feat A feature request, a feature deprecation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fpagnoux @benjello @bonjourmauko