Keep float as float32 when outputting them #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpagnoux
reviewed
Aug 6, 2018
| @@ -116,6 +116,8 @@ def calculate(): | |||
|
|
|||
| if variable.value_type == Enum: | |||
| entity_result = result.decode()[entity_index].name | |||
| elif variable.value_type == float: | |||
| entity_result = float(str(result[entity_index])) # To turn the float32 into a regular float without adding confusing extra decimals. There must be a better way. | |||
There was a problem hiding this comment.
I guess we didn't find a better way
There was a problem hiding this comment.
No, not for now, all the solutions I found involved stringinfying in some way.
fpagnoux
requested changes
Aug 6, 2018
CHANGELOG.md
Outdated
| @@ -1,5 +1,10 @@ | |||
| # Changelog | |||
|
|
|||
| ### 23.3.2 [#708](https://github.com/openfisca/openfisca-core/pull/708) | |||
|
|
|||
| - Addresses the typecasting from `float32` to `float64` made when outputing numbers in the API and in `openfisca-run-test`. | |||
There was a problem hiding this comment.
The first and most obvious thing reading the Changelog should be the impact and users (your second point), before the technicality of how we fixed the issues (your first point).
I'd also add a small example of what changed, (maybe a short extract of a JSON?) to help illustrate what has changed 🙂
fpagnoux
approved these changes
Aug 8, 2018
|
(Sorry, I should probably have let you the opportunity to review my editions, I was a little too enthusiastic to merge) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #699
Technical changes
openfisca-run-testfromfloat32tofloat64.