-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dump & restore to holders & simulations. #712
Conversation
Thanks for the PR @eraviart! A few general questions @benjello before looking more into details:
|
@fpagnoux : I knew that your input would be valuable !
|
Ok, I will try adjust the implem to take these two points into account :) |
e1dbbb4
to
d11fa9f
Compare
Tested on France calculating Mahdi, do you want to try the branch sees if it works for you, or should we go ahead and ask for a review? |
Thanks @fpagnoux ! Do you confirm that when restoring a simulation, the variables are kept back in RAM/disk according to the new I think we should ask for a review so I can go on and propagate to downstream packages. |
tests/core/test_dump_restore.py
Outdated
|
||
def test_dump_restore_different_simulations_different_variables(): | ||
data_storage_dir = tempfile.mkdtemp(prefix = "openfisca_") | ||
from .test_countries import tax_benefit_system |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use absolute import?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't use absolute imports as the tests
are not packaged in openfisca_core
.
Yes, |
Looks good to merge then @fpagnoux ! |
b7c832a
to
7a05d63
Compare
…that weren't dumped.
New features
EDIT (@fpagnoux)
Dump:
Restore: