Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow ParameterNode children to have a numeric keys #776

Merged
merged 2 commits into from
Nov 22, 2018
Merged

Allow ParameterNode children to have a numeric keys #776

merged 2 commits into from
Nov 22, 2018

Conversation

fpagnoux
Copy link
Member

  • Allow ParameterNode children to have a numeric keys
    • Before, an incorrect id would be set for these children, resulting to inconsistencies in the Web API.

@fpagnoux fpagnoux merged commit ef39fad into master Nov 22, 2018
@fpagnoux fpagnoux deleted the params-int-node branch November 22, 2018 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Morendil Morendil Morendil approved these changes

@sandcha sandcha Awaiting requested review from sandcha

@pblayo pblayo Awaiting requested review from pblayo

@bonjourmauko bonjourmauko Awaiting requested review from bonjourmauko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fpagnoux @Morendil