Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uniformize tests with the new API #781

Merged
merged 61 commits into from
Dec 5, 2018
Merged

Uniformize tests with the new API #781

merged 61 commits into from
Dec 5, 2018

Conversation

pblayo
Copy link
Member

@pblayo pblayo commented Nov 26, 2018 •
edited by fpagnoux
Loading

Connected to #716

@pblayo pblayo force-pushed the uniformize-tests-api branch 4 times, most recently from 0ac3010 to cc708b0 Compare November 26, 2018 16:03
@fpagnoux fpagnoux force-pushed the uniformize-tests-api branch 16 times, most recently from 0bace08 to 6075215 Compare November 28, 2018 06:01
@fpagnoux fpagnoux force-pushed the uniformize-tests-api branch from 89bfe88 to 3bd9c11 Compare November 28, 2018 13:07
fpagnoux
fpagnoux reviewed Nov 28, 2018
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
@Morendil
Copy link
Contributor

@fpagnoux Currently reviewing and refactoring, both to enhance testability and to gain a better understanding of the code. First pass this afternoon with @pblayo, I'll continue tomorrow with William (possible contributor in the future).

I may have a few other comments as well.

@Morendil Morendil force-pushed the uniformize-tests-api branch from a7a9d41 to 2e46843 Compare November 29, 2018 22:02
@fpagnoux fpagnoux force-pushed the uniformize-tests-api branch from b72408f to 7d883ed Compare December 5, 2018 20:15
@fpagnoux fpagnoux force-pushed the uniformize-tests-api branch from 7d883ed to 4ddca9e Compare December 5, 2018 20:21
@fpagnoux fpagnoux merged commit ee80a96 into master Dec 5, 2018
bonjourmauko
bonjourmauko reviewed Dec 5, 2018
View reviewed changes
setup.py
@@ -31,13 +33,13 @@
'flake8 >= 3.5.0, < 3.6.0',
'pycodestyle >= 2.3.0, < 2.4.0', # To avoid incompatibility with flake8
'pytest < 4.0.0',
'openfisca-country-template >= 3.4.0, < 4.0.0',
'openfisca-extension-template >= 1.1.3, < 2.0.0',
'openfisca-country-template >= 3.6.0rc0, < 4.0.0',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not forget to remove the release candidate.

@bonjourmauko bonjourmauko added the kind:feat A feature request, a feature deprecation label Dec 5, 2018
@fpagnoux fpagnoux deleted the uniformize-tests-api branch December 5, 2018 21:03
This was referenced Dec 14, 2018
Merged
Merged
This was referenced Apr 3, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpagnoux fpagnoux fpagnoux approved these changes

@sandcha sandcha sandcha left review comments

@bonjourmauko bonjourmauko bonjourmauko left review comments

@Morendil Morendil Morendil approved these changes

Assignees
No one assigned
Labels
kind:feat A feature request, a feature deprecation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pblayo @Morendil @fpagnoux @bonjourmauko @sandcha @willi-am-publi