Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict some Pytest options to 'make test', not all Pytest runs #839

Merged
merged 4 commits into from
Mar 15, 2019
Merged

Restrict some Pytest options to 'make test', not all Pytest runs #839

merged 4 commits into from
Mar 15, 2019

Conversation

Morendil
Copy link
Contributor

Technical changes

  • Make running Pytest more useful and less annoying

@Morendil Morendil requested a review from bonjourmauko March 11, 2019 13:36
@Morendil Morendil changed the title Only report coverage on 'make test', not on all Pytest runs Restrict some Pytest options to 'make test', not all Pytest runs Mar 11, 2019
@Morendil Morendil requested review from sandcha and fpagnoux March 14, 2019 13:26
sandcha
sandcha approved these changes Mar 15, 2019
View reviewed changes
Copy link
Collaborator

@sandcha sandcha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for hushing tests coverage on pytest @Morendil! ❤️

I would reset --exitfirst to the previous situation. Still, I'm too happy to limit test coverage to request changes.

Makefile Outdated
@@ -25,7 +25,7 @@ format-style:
autopep8 `git ls-files | grep "\.py$$"`

test: clean check-syntax-errors check-style
pytest
env PYTEST_ADDOPTS="--cov=openfisca_core --exitfirst" pytest
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 for limiting coverage calls!

Not a big fan of --exitfirst (stopping at first error) on this tag though as, make test is our only simple command to get an overview of the situation (linting, all tests statuses...).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

…which it was not giving us, previously!

You've convinced me, let's maximize make test, and fail fast only in CI.

@Morendil Morendil merged commit 49053ee into master Mar 15, 2019
@Morendil Morendil deleted the hush-coverage branch March 15, 2019 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandcha sandcha sandcha approved these changes

@bonjourmauko bonjourmauko Awaiting requested review from bonjourmauko

@fpagnoux fpagnoux Awaiting requested review from fpagnoux

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Morendil @sandcha