Remove extra_params altogether from Core #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpagnoux
approved these changes
Mar 20, 2019
|
Other than France I think the only reuser impacted was @robert49 with this notebook. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes
Remove extra_params altogether from Core. This puts all formulas on an equal footing and simplifies
simulation and data storage code.
Migration notes
For almost all users, no migration is needed.
You may be impacted only if you were computing (for instance in a notebook) one of the two variables from France that used this non-standard extension to the
calculate(variable, period)API:rsa_fictiforppa_fictive. In that case you had to supply the additional parametermois_demande. Usersaorppadirectly, and go back to the standard API.