Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix serialization error #900

Merged
merged 2 commits into from
Jul 17, 2019
Merged

Fix serialization error #900

merged 2 commits into from
Jul 17, 2019

Conversation

fpagnoux
Copy link
Member

@fpagnoux fpagnoux commented Jul 16, 2019 •
edited by bonjourmauko
Loading

Fixes #898
Fixes #899
Fixes openfisca/openfisca-france#1360

Alternative solution to #898

Bug fix

  • Fix serialisation error introduced in 34.2.9 in route /trace (Web API)
    • This was causing an Internal Server Error
    • Notably, numpy arrays were not being parsed correctly as not JSON serialisable

@fpagnoux fpagnoux requested review from bonjourmauko and sandcha July 16, 2019 19:46
@fpagnoux fpagnoux force-pushed the fix-json-serialization-trace branch from e09a66e to 5ee8f6e Compare July 16, 2019 19:46
@fpagnoux fpagnoux mentioned this pull request Jul 16, 2019
Closed
Br3nda
Br3nda reviewed Jul 16, 2019
View reviewed changes
tests/core/test_tracers.py Outdated
@@ -197,6 +197,18 @@ def test_flat_trace(tracer):
assert trace['b<2019>']['dependencies'] == []


def test_serialize_vectorial_param(tracer):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

@bonjourmauko bonjourmauko added the kind:fix Bugs are defects and failure demand. label Jul 16, 2019
@bonjourmauko bonjourmauko force-pushed the fix-json-serialization-trace branch from 5ee8f6e to a731178 Compare July 17, 2019 00:15
@bonjourmauko bonjourmauko merged commit 0fbdd00 into master Jul 17, 2019
@bonjourmauko bonjourmauko deleted the fix-json-serialization-trace branch July 17, 2019 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bonjourmauko bonjourmauko bonjourmauko approved these changes

@Br3nda Br3nda Br3nda approved these changes

@sandcha sandcha Awaiting requested review from sandcha

Assignees
No one assigned
Labels
kind:fix Bugs are defects and failure demand.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Serialization error in Web API with numpy arrays Erreur de serialisation de certaines paramètres (API)
3 participants
@fpagnoux @Br3nda @bonjourmauko