Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Control max_spiral_loops via YAML test files #985

Merged
merged 5 commits into from
Mar 26, 2021
Merged

Control max_spiral_loops via YAML test files #985

merged 5 commits into from
Mar 26, 2021

Conversation

benjello
Copy link
Member

@benjello benjello commented Mar 19, 2021 •
edited
Loading

Thanks for contributing to OpenFisca! Remove this line, as well as any other in the following that don't fit your contribution :)

Solves #956

New features

  • Introduce max_spiral_loops option in YAML test files
    • Allows for control of spiral depth for every test

cc @magemax

@benjello
Copy link
Member Author

Thanks @MattiSG and @maukoquiroga, this PR pass tests now.

@magemax @sandcha @maukoquiroga : I now need a review ... (it is a very simple modification)

guillett
guillett approved these changes Mar 26, 2021
View reviewed changes
Copy link
Member

@guillett guillett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Morendil Morendil removed their request for review March 26, 2021 09:01
@benjello benjello merged commit fd9ed8f into master Mar 26, 2021
@benjello benjello deleted the spiral-control-in-test branch March 26, 2021 09:32
@bonjourmauko bonjourmauko added the kind:feat A feature request, a feature deprecation label Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillett guillett guillett approved these changes

@sandcha sandcha Awaiting requested review from sandcha

@magemax magemax Awaiting requested review from magemax

@bonjourmauko bonjourmauko Awaiting requested review from bonjourmauko

Assignees
No one assigned
Labels
kind:feat A feature request, a feature deprecation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benjello @guillett @bonjourmauko