Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase resilience of web API tests #987

Merged
merged 3 commits into from
Mar 23, 2021
Merged

Conversation

MattiSG
Copy link
Member

@MattiSG MattiSG commented Mar 23, 2021

Technical changes

  • Test for presence of strings rather than exact matches in Web API responses, as most other Web API tests did.

Supersedes #986, re-implements #981, would have avoided #980.

@MattiSG MattiSG requested a review from bonjourmauko March 23, 2021 09:00
@bonjourmauko
Copy link
Member

Thanks !

Copy link
Member

@augusto-herrmann augusto-herrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is good practice. I believe minor changes in wording of the texts should not cause the tests to fail.

@MattiSG MattiSG force-pushed the resilient-doc-test-update branch from 9cf28b0 to ac4faf2 Compare March 23, 2021 17:57
@MattiSG
Copy link
Member Author

MattiSG commented Mar 23, 2021

Using this PR as a knight for a typo in README and a minor gitignore change to decrease administrative costs.

## Installation

If you're developping your own country package, you don't need to explicitly install OpenFisca-Core. It just needs to appear [in your package dependencies](https://github.com/openfisca/openfisca-france/blob/18.2.1/setup.py#L53).
If you're developing your own country package, you don't need to explicitly install OpenFisca-Core. It just needs to appear [in your package dependencies](https://github.com/openfisca/openfisca-france/blob/18.2.1/setup.py#L53).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MattiSG MattiSG merged commit 81abfac into master Mar 23, 2021
@MattiSG MattiSG deleted the resilient-doc-test-update branch March 23, 2021 21:14
@bonjourmauko bonjourmauko restored the resilient-doc-test-update branch March 23, 2021 22:27
@bonjourmauko bonjourmauko added the kind:refactor Refactoring and code cleanup label Mar 26, 2021
RamParameswaran added a commit that referenced this pull request Apr 1, 2021
RamParameswaran added a commit that referenced this pull request Apr 15, 2021
@bonjourmauko bonjourmauko deleted the resilient-doc-test-update branch September 29, 2021 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:refactor Refactoring and code cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants