Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve copywriting for top level elements #298

Merged
merged 12 commits into from
May 21, 2024
Merged

Improve copywriting for top level elements #298

merged 12 commits into from
May 21, 2024

Conversation

verbman
Copy link
Contributor

@verbman verbman commented May 12, 2024

Top level documents, and contribute section (excluding tests).
(Note also howto_docker from installation)

@verbman verbman requested a review from MattiSG May 12, 2024 21:45
@MattiSG MattiSG changed the title Training review part 1 Improve copywriting for top level elements May 14, 2024
Copy link
Member

@MattiSG MattiSG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, many good improvements!

source/contribute/commit-messages.md Outdated Show resolved Hide resolved
source/contribute/commit-messages.md Outdated Show resolved Hide resolved
* [OpenFisca-Documentation](https://github.com/openfisca/openfisca-doc)
* [Legislation-Explorer](https://github.com/openfisca/legislation-explorer)
* [OpenFisca-Survey-Manager](https://github.com/openfisca/openfisca-survey-manager)
* [OpenFisca-France](https://github.com/openfisca/openfisca-france) and other models etc.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not link to a specific country here, but rather introduce the distinction between “Core” packages that are shared by everyone, and country packages that can be held by any organisation.

Let's also avoid referring to “The OpenFisca project”.

source/contribute/developer-guide.md Outdated Show resolved Hide resolved
source/contribute/documentation.md Outdated Show resolved Hide resolved
source/contribute/variables-naming.md Outdated Show resolved Hide resolved
source/contribute/variables-naming.md Outdated Show resolved Hide resolved
source/index.md Show resolved Hide resolved
source/installation/howto_docker.md Show resolved Hide resolved
source/license.md Show resolved Hide resolved
@verbman verbman requested a review from MattiSG May 20, 2024 09:30
Copy link
Member

@MattiSG MattiSG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks a lot, I'm excited to finally see some layers of dust being shaken off 😊

source/contribute/commit-messages.md Show resolved Hide resolved
source/contribute/developer-guide.md Show resolved Hide resolved
source/contribute/developer-guide.md Show resolved Hide resolved
source/contribute/guidelines.md Show resolved Hide resolved
source/contribute/guidelines.md Outdated Show resolved Hide resolved
verbman and others added 11 commits May 20, 2024 22:50
Co-authored-by: Matti Schneider <matti.schneider@openfisca.fr>
Co-authored-by: Matti Schneider <matti.schneider@openfisca.fr>
Co-authored-by: Matti Schneider <matti.schneider@openfisca.fr>
Co-authored-by: Matti Schneider <matti.schneider@openfisca.fr>
@verbman verbman force-pushed the training-review branch from 5e17127 to 550dcbf Compare May 21, 2024 01:22
@verbman verbman merged commit 5cb1905 into master May 21, 2024
2 checks passed
@verbman verbman deleted the training-review branch May 21, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants