Exports flattened output for erfs_fpr #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@benjello Instead of merging this PR into
|
benjello
requested changes
Oct 21, 2019
| @@ -54,7 +54,7 @@ def build(year: int) -> None: | |||
| # | |||
| # On crée une df par entité par période. | |||
| # Elles sont stockées dans un fichier h5 | |||
| final.create_input_data_frame(year = year) | |||
| final.create_input_data_frame(year = year,export_flattened_df=True) | |||
| @@ -15,7 +15,7 @@ | |||
|
|
|||
|
|
|||
| @temporary_store_decorator(file_name = 'erfs_fpr') | |||
| def create_input_data_frame(temporary_store = None, year = None): | |||
| def create_input_data_frame(temporary_store = None, year = None,export_flattened_df=False): | |||
| @@ -95,7 +95,11 @@ def create_input_data_frame(temporary_store = None, year = None): | |||
| ) | |||
|
|
|||
| individus = format_ids_and_roles(individus) | |||
|
|
|||
| if export_flattened_df: | |||
| supermerge=individus.merge(menages,right_index=True,left_on="idmen",suffixes=("","_x")) | |||
There was a problem hiding this comment.
space around = and after commas.
| if export_flattened_df: | ||
| supermerge=individus.merge(menages,right_index=True,left_on="idmen",suffixes=("","_x")) | ||
| print(len(individus),len(supermerge)) | ||
| supermerge.to_hdf("dummy_data.h5",key="input") |
There was a problem hiding this comment.
"dummy_data.h5" should be an additional argument
benjello
approved these changes
Oct 22, 2019
|
Actually it would be better to check it carefully. But I do not have much time right now. |
magemax
force-pushed
the
flatten_erfs_fpr
branch
from
3b0b471 to
b6a62ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New features
export_flattened_dfargument increate_input_data_framefunctiondummy_data.h5file export that contains only one flattened table (one line per individual) instead of exporting an h5 file with several tables (one with individual and one for households). This fits better certain ways of importing back the data into openfisca (e.g. LexImpact).numexprtop version to the version used by Core.