Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase refacto scenario #241

Merged
merged 28 commits into from
Nov 8, 2023
Merged

Rebase refacto scenario #241

merged 28 commits into from
Nov 8, 2023

Conversation

benjello
Copy link
Member

Thanks for contributing to OpenFisca-France-Data! Remove this line, as well as any other in the following that don't fit your contribution :)

Breaking changes

  • In some module:
    • Remove…

New features

  • Introduce some_function()
    • Allows for…

Deprecations

  • Deprecate some_function.
    • The functionality is now provided by…

Technical changes

  • Rename private_function.

@clallemand clallemand self-requested a review November 7, 2023 15:48
@clallemand clallemand changed the title Draft: Rebase refacto scenario Rebase refacto scenario Nov 7, 2023
@clallemand clallemand mentioned this pull request Nov 7, 2023
@clallemand
Copy link
Contributor

@benjello : voici une proposition de ce que contient cette MR :

Breaking changes

Adapte le dépôt au passage à openfisca-survey-manager 2.0.0 qui constitue une refactorisation de l'objet survey-scenario et des simulations qui sont dedans. Cela concerne donc les parties de ce dépôts qui héritent d'objets d'openfisca-survey-manager :

  • openfisca_france_data/aggregates.py
  • openfisca_france_data/surveys.py

Les autres modifications sont des adaptions syntaxique mineurs du fait de cette adaptation

Copy link
Contributor

@clallemand clallemand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tout me semble bon, les tests sur données passent !

@clallemand
Copy link
Contributor

@benjello je te laisse merger si tout te semble ok !

@clallemand clallemand self-requested a review November 7, 2023 16:50
@clallemand
Copy link
Contributor

@benjello my bad les agrégats ne tournent plus avec mon dernier commit je regarde ça

@clallemand clallemand merged commit 502c9c7 into master Nov 8, 2023
12 checks passed
@clallemand clallemand deleted the rebase-refacto-scenario branch November 8, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants