Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make x86 target flags more specific #1819

Closed
tobil4sk opened this issue Jul 14, 2024 · 1 comment
Closed

Make x86 target flags more specific #1819

tobil4sk opened this issue Jul 14, 2024 · 1 comment

Comments

@tobil4sk
Copy link
Member

As discussed in #1813, -64 and -32 are currently used in a lot of places to mean x86_64 and x86_32 respectively. Now that arm64 systems are widespread (and 8.2.0-Dev has arm64 Mac support), which is also a 64 bit architecture, it would be better to have more specific flags that are specifically for x86 architectures.

It looks like the ios target already uses the i386 flag:

if (project.targetFlags.exists("i386") || project.targetFlags.exists("32"))

@joshtynjala
Copy link
Member

Interesting background here on x86, i386, and IA-32, which all can refer to 32-bit Intel architecture processors: https://unix.stackexchange.com/questions/489145/why-do-linux-world-use-the-term-i386-instead-of-x86

Similarly, 64-bit Intel/AMD can be x86_64, x64, AMD64, and Intel 64 (but not IA-64, which was used for Intel Itanium instead).

EliteMasterEric added a commit to FunkinCrew/lime that referenced this issue Jul 29, 2024
* Fix curl static linking on mac

This was overlooked in openfl#1682

* prepare for Lime 8.1.3

* tools: allow -x86_64 and -x86_32 as command line flags to select those architectures instead of defaults (closes openfl#1819)

Still supports -32 and -64, though, for backwards compatibility. We could consider removing those in Lime 9.

* release date

---------

Co-authored-by: Tobiasz Laskowski <tobil4sk@outlook.com>
Co-authored-by: Chris Speciale <christopher.gaf@gmail.com>
Co-authored-by: Josh Tynjala <joshtynjala@bowlerhat.dev>
NotHyper-474 pushed a commit to NotHyper-474/lime that referenced this issue Oct 11, 2024
* Fix curl static linking on mac

This was overlooked in openfl#1682

* prepare for Lime 8.1.3

* tools: allow -x86_64 and -x86_32 as command line flags to select those architectures instead of defaults (closes openfl#1819)

Still supports -32 and -64, though, for backwards compatibility. We could consider removing those in Lime 9.

* release date

---------

Co-authored-by: Tobiasz Laskowski <tobil4sk@outlook.com>
Co-authored-by: Chris Speciale <christopher.gaf@gmail.com>
Co-authored-by: Josh Tynjala <joshtynjala@bowlerhat.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants