Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(API): always filter input data fields before POST #1034

Merged
merged 1 commit into from
Nov 13, 2024
Merged

refactor(API): always filter input data fields before POST #1034

merged 1 commit into from
Nov 13, 2024

Conversation

raphodn
Copy link
Member

@raphodn raphodn commented Nov 13, 2024

What

Refactoring in api.js

  • avoid having to pass all the price/proof parameters when creating/updating the objects
  • always filter the input data with the expected body keys

Why

  • simplify the code
  • make space for a new "source" param

@raphodn raphodn merged commit b8927ed into master Nov 13, 2024
6 of 7 checks passed
@raphodn raphodn deleted the raphodn/api-data-filter-refactor branch November 13, 2024 16:36
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Nov 13, 2024
Merged
@raphodn raphodn mentioned this pull request Nov 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@raphodn raphodn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@raphodn