Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCR and packaging: move code from Smoothie #494

Closed
monsieurtanuki opened this issue Jun 25, 2022 · 0 comments · Fixed by #497
Closed

OCR and packaging: move code from Smoothie #494

monsieurtanuki opened this issue Jun 25, 2022 · 0 comments · Fixed by #497
Assignees
@monsieurtanuki
Labels
✨ enhancement New feature or request OCR Optical Character Recognition 📦 Packaging

Comments

@monsieurtanuki
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Some interesting code was written in Smoothie: openfoodfacts/smooth-app#2383, in tmp_ocr_packaging_result.dart (class OcrPackagingResult) and ocr_packaging_helper.dart (method extractPackaging).

Describe the solution you'd like
The code should be moved to this package.

Describe alternatives you've considered
No rush, we can still leave things the way they are.
@monsieurtanuki monsieurtanuki self-assigned this Jun 26, 2022
monsieurtanuki added a commit to monsieurtanuki/openfoodfacts-dart that referenced this issue Jun 26, 2022
@monsieurtanuki
feat: openfoodfacts#494 - added OCR for packaging
7e12d2c 
New files:
* `OcrPackagingResult.dart`: Result from OCR applied to packaging.
* `OcrPackagingResult.g.dart`: generated.

Impacted files:
* `OcrPackagingResult.dart`: mere refactoring in order to match the new `OcrPackagingResult` class.
* `openfoodfacts.dart`: new OCR method `extractPackaging`; refactored `extractIngredients` and fixed a bug.
@monsieurtanuki monsieurtanuki mentioned this issue Jun 26, 2022
Merged
monsieurtanuki added a commit that referenced this issue Jun 29, 2022
@monsieurtanuki
feat: #494 - added OCR for packaging (#497)
4c14abb 
New files:
* `OcrPackagingResult.dart`: Result from OCR applied to packaging.
* `OcrPackagingResult.g.dart`: generated.

Impacted files:
* `OcrPackagingResult.dart`: mere refactoring in order to match the new `OcrPackagingResult` class.
* `openfoodfacts.dart`: new OCR method `extractPackaging`; refactored `extractIngredients` and fixed a bug.
@github-actions github-actions bot mentioned this issue Jun 29, 2022
Merged
@monsieurtanuki monsieurtanuki mentioned this issue Jun 29, 2022
Closed
2 tasks
@teolemon teolemon added 📦 Packaging OCR Optical Character Recognition ✨ enhancement New feature or request labels Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@monsieurtanuki monsieurtanuki

Labels
✨ enhancement New feature or request OCR Optical Character Recognition 📦 Packaging
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: #494 - added OCR for packaging monsieurtanuki/openfoodfacts-dart
2 participants
@teolemon @monsieurtanuki