Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #503 - added the "all to-be-completed products" configuration #504

Merged
merged 9 commits into from
Jul 2, 2022

Conversation

monsieurtanuki
Copy link
Contributor

New files:

  • api_getToBeCompletedProducts_test.dart: Integration tests related to ToBeCompletedQueryConfiguration
  • ToBeCompletedConfiguration.dart: Query Configuration for all the to-be-completed products.

What

  • In combination with getProducts, ToBeCompletedConfiguration will return the list of all to-be-completed products.

Fixes bug(s)

monsieurtanuki and others added 8 commits June 7, 2022 22:28
…ment

Impacted files:
* `api_saveProduct_test.dart`: unrelated test skip
* `KnowlegdePanelElement.dart`: `title` is now optional
* `KnowlegdePanelElement.g.dart`: generated
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
# Conflicts:
#	CHANGELOG.md
#	version.txt
…nfiguration

New files:
* `api_getToBeCompletedProducts_test.dart`: Integration tests related to `ToBeCompletedQueryConfiguration`
* `ToBeCompletedConfiguration.dart`: Query Configuration for all the to-be-completed products.
@monsieurtanuki monsieurtanuki requested a review from a team as a code owner June 30, 2022 17:14
@monsieurtanuki monsieurtanuki requested a review from M123-dev June 30, 2022 17:15
Impacted file:
* `api_saveProduct_test.dart`: unrelated failing test skip
Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@monsieurtanuki monsieurtanuki merged commit b7c16ed into openfoodfacts:master Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

From Smoothie: "all products to be completed" query configuration
2 participants