Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

From Smoothie: "all products to be completed" query configuration #503

Closed
monsieurtanuki opened this issue Jun 30, 2022 · 0 comments · Fixed by #504
Closed

From Smoothie: "all products to be completed" query configuration #503

monsieurtanuki opened this issue Jun 30, 2022 · 0 comments · Fixed by #504
Assignees
@monsieurtanuki

Comments

@monsieurtanuki
Copy link
Contributor

Class ToBeCompletedQueryConfiguration that was coded in Smoothie first and that is meaningful here too.
cf. openfoodfacts/smooth-app#2441
cf. tmp_to_be_completed_query_configuration.dart
@monsieurtanuki monsieurtanuki self-assigned this Jun 30, 2022
monsieurtanuki added a commit to monsieurtanuki/openfoodfacts-dart that referenced this issue Jun 30, 2022
@monsieurtanuki
feat: openfoodfacts#503 - added the "all to-be-completed products" co…
2200efb 
…nfiguration

New files:
* `api_getToBeCompletedProducts_test.dart`: Integration tests related to `ToBeCompletedQueryConfiguration`
* `ToBeCompletedConfiguration.dart`: Query Configuration for all the to-be-completed products.
@monsieurtanuki monsieurtanuki mentioned this issue Jun 30, 2022
Merged
monsieurtanuki added a commit to monsieurtanuki/openfoodfacts-dart that referenced this issue Jun 30, 2022
@monsieurtanuki
feat: openfoodfacts#503 - unrelated failing test skip
b3de56c 
Impacted file:
* `api_saveProduct_test.dart`: unrelated failing test skip
monsieurtanuki added a commit that referenced this issue Jul 2, 2022
@monsieurtanuki
feat: #503 - added the "all to-be-completed products" configuration (#…
b7c16ed 
…504)

New files:
* `api_getToBeCompletedProducts_test.dart`: Integration tests related to `ToBeCompletedQueryConfiguration`
* `ToBeCompletedConfiguration.dart`: Query Configuration for all the to-be-completed products.

Impacted file:
* `api_saveProduct_test.dart`: unrelated failing test skip
@github-actions github-actions bot mentioned this issue Jul 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@monsieurtanuki monsieurtanuki

Labels
None yet
Projects
Dart package - Support for new APIs and issues
Status: To do
Milestone
No milestone
1 participant
@monsieurtanuki