fix: Migrated the JS from template form to real JS #9966
Conversation
github-actions
bot
added
JavaScript
Template::Toolkit
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9966 +/- ##
==========================================
+ Coverage 49.54% 49.68% +0.14%
==========================================
Files 67 71 +4
Lines 20650 20980 +330
Branches 4980 5025 +45
==========================================
+ Hits 10231 10424 +193
- Misses 9131 9264 +133
- Partials 1288 1292 +4 ☔ View full report in Codecov by Sentry. |
|
@stephanegigandet could you pls merge this pull request. |
MonalikaPatnaik
changed the title
|
@stephanegigandet could you pls merge this? I don't know why the unit test check is failing in this PR:( |
| @@ -411,6 +411,8 @@ <h3 class="title-5 text-medium">[% lang('footer_discover_the_project') %]</h3> | |||
| <script src="[% static_subdomain %]/js/dist/display.js"></script> | |||
| <script src="[% static_subdomain %]/js/dist/stikelem.js"></script> | |||
| <script src="[% static_subdomain %]/js/dist/scrollNav.js"></script> | |||
| <script src="[% static_subdomain %]/js/dist/togglepassword.js"></script> | |||
There was a problem hiding this comment.
Those 2 scripts are only needed on the sign-in and user page, can you load them only on those pages instead of all pages of the website?
|
|
|
||
| <script> | ||
| $(function() { | ||
|
|
||
| $(document).ready( function () { |
There was a problem hiding this comment.
I think this should not have been removed: when I check the "this is a pro account" checkbox, I'm not shown the warning anymore:
This is what we have in production:
Fixes #9106
Migrated the code of togglepassword.tt.js and user_form.tt.js scripts to /html/js/ as static JS files.