Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encoding issue in Ukrainian #2291

Closed
1 task
teolemon opened this issue Jun 16, 2022 · 1 comment · Fixed by #2657
Closed
1 task

Encoding issue in Ukrainian #2291

teolemon opened this issue Jun 16, 2022 · 1 comment · Fixed by #2657
Assignees
@monsieurtanuki
Labels
🐛 bug Something isn't working 🌐 l10n 🎯 P1

Comments

@teolemon
Copy link
Member

What

  • Encoding issue in Ukrainian

image
@monsieurtanuki
Copy link
Contributor

I suspect those guys: https://en.wikipedia.org/wiki/Yi_(Cyrillic) and https://en.wikipedia.org/wiki/Dotted_I_(Cyrillic)
I've checked on my ios emulator: that is correctly displayed, though.

What can we do?

  • check on your device if the problem is actually with Yi and dotted I
  • should we "correct" the translated text - in this case the substitution would be easy as "Yi" looks very similar to more latin "ï" (ï), and dotted I to the latin "i"
  • that would mean we should maintain a substitution map, and apply it to every text displayed - or every text translated...

@teolemon teolemon added 🐛 bug Something isn't working 🎯 P1 🌐 l10n labels Jun 21, 2022
@monsieurtanuki monsieurtanuki mentioned this issue Jul 25, 2022
Closed
@monsieurtanuki monsieurtanuki self-assigned this Jul 25, 2022
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Jul 25, 2022
@monsieurtanuki
fix: openfoodfacts#2291 - removed flawed specific font (back to defau…
ba2852b 
…lt fonts)

Deleted files:
* `OFL.txt`
* `PlusJakartaSans-Bold.ttf`
* `PlusJakartaSans-Regular.ttf`

Impacted files:
* `main.dart`: removed font licence registering
* `pubspec.yaml`: removed specified fonts (back to default fonts)
* `smooth_theme.dart`: removed specified fonts (back to default fonts)
@monsieurtanuki monsieurtanuki mentioned this issue Jul 25, 2022
Merged
monsieurtanuki added a commit that referenced this issue Jul 27, 2022
@monsieurtanuki
fix: #2291 - removed flawed specific font (back to default fonts) (#2657
180c817 
)

Deleted files:
* `OFL.txt`
* `PlusJakartaSans-Bold.ttf`
* `PlusJakartaSans-Regular.ttf`

Impacted files:
* `main.dart`: removed font licence registering
* `pubspec.yaml`: removed specified fonts (back to default fonts)
* `smooth_theme.dart`: removed specified fonts (back to default fonts)
Repository owner moved this from To discuss and validate to Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Jul 27, 2022
@github-actions github-actions bot mentioned this issue Jul 27, 2022
Merged
@github-actions github-actions bot mentioned this issue Aug 10, 2022
Merged
@github-actions github-actions bot mentioned this issue Sep 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@monsieurtanuki monsieurtanuki

Labels
🐛 bug Something isn't working 🌐 l10n 🎯 P1
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: #2291 - removed flawed specific font (back to default fonts) monsieurtanuki/smooth-app
2 participants
@teolemon @monsieurtanuki