-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Background image upload #2433
fix: Background image upload #2433
Conversation
as image.others might fail
…into background-image-upload
…into background-image-upload
Codecov Report
@@ Coverage Diff @@
## develop #2433 +/- ##
==========================================
- Coverage 7.04% 6.88% -0.17%
==========================================
Files 219 221 +2
Lines 10874 11161 +287
==========================================
+ Hits 766 768 +2
- Misses 10108 10393 +285
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @AshAman999, that looks rather good.
I've never used workmanager
before though, therefore there are things I may have missed.
Beyond my detailed comments, I have some questions:
- I'm not convinced by the increasing delay (what delay is that btw? the delay from the moment I clicked on upload or from the latest unsuccessful attempt?). I guess a call to sentry would make sense ("hey we've got this guy and we cannot upload his picture"), as would an alert to the end-user.
- Wouldn't it be nice to display somewhere the list of the pending tasks?
- How do you refresh the app when the picture is uploaded? I saw something about the carousel, but I don't think it would refresh a product page, would it?
packages/smooth_app/lib/pages/product/confirm_and_upload_picture.dart
Outdated
Show resolved
Hide resolved
packages/smooth_app/lib/pages/product/confirm_and_upload_picture.dart
Outdated
Show resolved
Hide resolved
packages/smooth_app/lib/pages/product/confirm_and_upload_picture.dart
Outdated
Show resolved
Hide resolved
packages/smooth_app/lib/pages/product/product_image_gallery_view.dart
Outdated
Show resolved
Hide resolved
packages/smooth_app/lib/cards/data_cards/image_upload_card.dart
Outdated
Show resolved
Hide resolved
…into background-image-upload
…into background-image-upload
…to background-image-upload
…to background-image-upload
…into background-image-upload
packages/smooth_app/lib/pages/product/add_new_product_page.dart
Outdated
Show resolved
Hide resolved
…into background-image-upload
…into background-image-upload
are there any outstanding issues left @AshAman999 @g123k ? |
@teolemon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
We can now test the feature
Ok, going to merge |
What
workmanager
to do image upload in the backgroundBenefits
Problems
workmanager
[WIP] alternate ways to let users know if the task is done(possibly other menus)Fixes bug(s)
Part of