Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #2563 - edit product page - added top barcode display and leading/trailing icons #2567

Merged
merged 3 commits into from
Jul 10, 2022

Conversation

monsieurtanuki
Copy link
Contributor

Impacted files:

  • edit_product_page.dart: added barcode display; added leading icon and trailing arrow to items
  • pubspec.lock: wtf
  • pubspec.yaml: added package barcode_widget
  • simple_input_page_helpers.dart: added leading icon

What

  • New UI for edit product page.
  • Barcode display on top.
  • Leading icon for each item (default: "edit").
  • Same trailing icon for all items (forward arrow).
  • The leading icons are currently not the target ones; to be fine-tuned later according to Better UI/UX for "edit product" page #2563.

Screenshot

Capture d’écran 2022-07-10 à 16 40 27

Part of

…lay and leading/trailing icons

Impacted files:
* `edit_product_page.dart`: added barcode display; added leading icon and trailing arrow to items
* `pubspec.lock`: wtf
* `pubspec.yaml`: added package `barcode_widget`
* `simple_input_page_helpers.dart`: added leading icon
@monsieurtanuki monsieurtanuki requested a review from a team as a code owner July 10, 2022 14:41
@monsieurtanuki monsieurtanuki requested a review from teolemon July 10, 2022 14:41
@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2022

Codecov Report

Merging #2567 (7b01b90) into develop (2ea0da3) will decrease coverage by 1.30%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           develop   #2567      +/-   ##
==========================================
- Coverage     8.86%   7.55%   -1.31%     
==========================================
  Files          161     210      +49     
  Lines         6623   10093    +3470     
==========================================
+ Hits           587     763     +176     
- Misses        6036    9330    +3294     
Impacted Files Coverage Δ
...kages/smooth_app/lib/widgets/attribute_button.dart 0.00% <0.00%> (-92.00%) ⬇️
...s/smooth_app/lib/data_models/user_preferences.dart 8.73% <0.00%> (-23.57%) ⬇️
packages/smooth_app/lib/themes/smooth_theme.dart 60.00% <0.00%> (-22.98%) ⬇️
...p/lib/generic_lib/dialogs/smooth_alert_dialog.dart 15.29% <0.00%> (-18.92%) ⬇️
...mooth_app/lib/data_models/product_preferences.dart 24.65% <0.00%> (-6.78%) ⬇️
packages/smooth_app/lib/main.dart 14.16% <0.00%> (-3.73%) ⬇️
.../smooth_app/lib/pages/onboarding/welcome_page.dart 0.00% <0.00%> (-3.13%) ⬇️
.../smooth_app/lib/pages/onboarding/scan_example.dart 0.00% <0.00%> (-2.28%) ⬇️
...p/lib/pages/onboarding/consent_analytics_page.dart 0.00% <0.00%> (-1.57%) ⬇️
...smooth_app/lib/pages/product/new_product_page.dart 0.00% <0.00%> (-0.88%) ⬇️
... and 219 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4ea159...7b01b90. Read the comment docs.

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shopping_cart for stores
restaurant for categories
factory for traceability codes
local_offer for labels
public for countries

Impacted file:
* `simple_input_page_helpers.dart`
@monsieurtanuki
Copy link
Contributor Author

Just PR'ed:
Capture d’écran 2022-07-10 à 17 40 46

@teolemon
Copy link
Member

recycling https://fonts.google.com/icons?selected=Material+Icons&icon.set=Material+Symbols

Impacted file:
* `edit_product_page.dart`
@monsieurtanuki
Copy link
Contributor Author

Just PR'ed "recycling" icon for packaging item.

Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @monsieurtanuki looks great.

Some more UI fine-tuning needed, coloring some margin and no elevation to look in the mocks. Doesn't have to be in this PR but we should do it before the next release

@monsieurtanuki monsieurtanuki merged commit b16d6d6 into openfoodfacts:develop Jul 10, 2022
@teolemon
Copy link
Member

thanks @monsieurtanuki

@monsieurtanuki
Copy link
Contributor Author

Thank you @M123-dev @teolemon!
Does it look 100% like the mock? No it doesn't, but we're better off with this PR merged.
Now anybody can start from there if a perfect match with the mock is needed - I would say that there are other issues with higher priorities to solve before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants