-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: #2563 - edit product page - added top barcode display and leading/trailing icons #2567
feat: #2563 - edit product page - added top barcode display and leading/trailing icons #2567
Conversation
…lay and leading/trailing icons Impacted files: * `edit_product_page.dart`: added barcode display; added leading icon and trailing arrow to items * `pubspec.lock`: wtf * `pubspec.yaml`: added package `barcode_widget` * `simple_input_page_helpers.dart`: added leading icon
Codecov Report
@@ Coverage Diff @@
## develop #2567 +/- ##
==========================================
- Coverage 8.86% 7.55% -1.31%
==========================================
Files 161 210 +49
Lines 6623 10093 +3470
==========================================
+ Hits 587 763 +176
- Misses 6036 9330 +3294
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shopping_cart for stores
restaurant for categories
factory for traceability codes
local_offer for labels
public for countries
Impacted file: * `simple_input_page_helpers.dart`
recycling https://fonts.google.com/icons?selected=Material+Icons&icon.set=Material+Symbols |
Impacted file: * `edit_product_page.dart`
Just PR'ed "recycling" icon for packaging item. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks @monsieurtanuki looks great.
Some more UI fine-tuning needed, coloring some margin and no elevation to look in the mocks. Doesn't have to be in this PR but we should do it before the next release
thanks @monsieurtanuki |
Impacted files:
edit_product_page.dart
: added barcode display; added leading icon and trailing arrow to itemspubspec.lock
: wtfpubspec.yaml
: added packagebarcode_widget
simple_input_page_helpers.dart
: added leading iconWhat
Screenshot
Part of