-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: #2291 - removed flawed specific font (back to default fonts) #2657
fix: #2291 - removed flawed specific font (back to default fonts) #2657
Conversation
…lt fonts) Deleted files: * `OFL.txt` * `PlusJakartaSans-Bold.ttf` * `PlusJakartaSans-Regular.ttf` Impacted files: * `main.dart`: removed font licence registering * `pubspec.yaml`: removed specified fonts (back to default fonts) * `smooth_theme.dart`: removed specified fonts (back to default fonts)
Codecov Report
@@ Coverage Diff @@
## develop #2657 +/- ##
==========================================
- Coverage 8.86% 7.31% -1.56%
==========================================
Files 161 218 +57
Lines 6623 10491 +3868
==========================================
+ Hits 587 767 +180
- Misses 6036 9724 +3688
Help us with your feedback. Take ten seconds to tell us how you rate us. |
I guess it is the right thing to do, but we're loosing the unique identity
We should probably ask Quentin for a similar font replacement. Meanwhile, is there a way to disable it only for non-latin languages ? |
@teolemon What about merging this PR first, and find the bullet-proof font / the perfect font combo later? I'm hyper sensitive to 1-star ratings, and if I think about the time and energy spent on the rest of the app, I find it a bit depressing to have users reject the app for legitimate reasons that would require an easy fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good and I totally agree with the 1 Star reviews
Deleted files:
OFL.txt
PlusJakartaSans-Bold.ttf
PlusJakartaSans-Regular.ttf
Impacted files:
main.dart
: removed font licence registeringpubspec.yaml
: removed specified fonts (back to default fonts)smooth_theme.dart
: removed specified fonts (back to default fonts)What
Screenshot
Ukraine/Ukrainian:
Fixes bug(s)