Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Placement of Food prefs is ugly #2776

Closed
teolemon opened this issue Aug 11, 2022 · 8 comments · Fixed by #2780
Closed

Placement of Food prefs is ugly #2776

teolemon opened this issue Aug 11, 2022 · 8 comments · Fixed by #2780
Assignees
@monsieurtanuki

Comments

@teolemon
Copy link
Member

What

  • Placement of Food prefs is ugly
  • I would expect it left aligned with the rest of the screen
    image
@monsieurtanuki
Copy link
Contributor

@teolemon You mean you prefer something like that (I added the grey background just for horizontal alignment check):
Capture d’écran 2022-08-11 à 19 15 45

@AshAman999
Copy link
Member

I guess it's about the title `Food Preferences, maybe we could left align that text

@monsieurtanuki
Copy link
Contributor

I guess it's about the title `Food Preferences, maybe we could left align that text

That was my initial interpretation too.
But that would mean that figma is wrong, and that all user preference page headers are wrong. Which is possible.
I cannot see how we should NOT center the logo and the text, or just NOT center the text while keeping the logo to the center...

@AshAman999
Copy link
Member

At least here in the screenshot by pierre it looks bad, maybe reducing font size might help ❓

@monsieurtanuki
Copy link
Contributor

I don't know what Pierre means. But reducing the font size won't help. Putting the header title in a SizedBox and an AutoSizeText would.

@teolemon
Copy link
Member Author

The mockup didn't take into account that the text would be long.

@teolemon
Copy link
Member Author

Screenshot_20220811-213533.png

@teolemon
Copy link
Member Author

Also, since we don't match them, the original was left aligned

@monsieurtanuki monsieurtanuki self-assigned this Aug 11, 2022
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Aug 12, 2022
@monsieurtanuki
fix: openfoodfacts#2776 - more standard user preferences app bar
2eeb854 
Impacted files:
* `user_preferences_account.dart`: unrelated uniformization of list tile display in preferences
* `user_preferences_food.dart`: unrelated uniformization of list tile display in preferences
* `user_preferences_page.dart`: removed the sliver effect
@monsieurtanuki monsieurtanuki mentioned this issue Aug 12, 2022
Merged
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Aug 12, 2022
@monsieurtanuki
fix: openfoodfacts#2776 - golden refresh
11d13ce
monsieurtanuki added a commit that referenced this issue Aug 12, 2022
@monsieurtanuki
fix: #2776 - more standard user preferences app bar (#2780)
4abe9fe 
Impacted files:
* golden files
* `user_preferences_account.dart`: unrelated uniformization of list tile display in preferences
* `user_preferences_food.dart`: unrelated uniformization of list tile display in preferences
* `user_preferences_page.dart`: removed the sliver effect
Repository owner moved this from To discuss and validate to Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Aug 12, 2022
@github-actions github-actions bot mentioned this issue Aug 12, 2022
Merged
@github-actions github-actions bot mentioned this issue Sep 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@monsieurtanuki monsieurtanuki

Labels
None yet
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: #2776 - more standard user preferences app bar monsieurtanuki/smooth-app
3 participants
@teolemon @monsieurtanuki @AshAman999