Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product Addition - The image upload snackbar is blocking the finish button while it's visible #2944

Closed
Tracked by #1379
teolemon opened this issue Sep 6, 2022 · 14 comments
Assignees
Labels
🐛 bug Something isn't working good first issue Good for newcomers Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. 🎨 UI / UX

Comments

@teolemon
Copy link
Member

teolemon commented Sep 6, 2022

What

  • The image upload snackbar is blocking the finish button while it's visible

Screenshot/Mockup/Before-After

Part of

@teolemon teolemon added 🐛 bug Something isn't working 🎨 UI / UX Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. ⏲️ 5 minute fix labels Sep 6, 2022
@teolemon teolemon moved this from To discuss and validate to Todo (ready 2 dev) in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Sep 6, 2022
@monsieurtanuki
Copy link
Contributor

Two suggestions:

  • move the "finish" button "a bit higher"
  • instead of the "finish" button, use an extended FloatingActionButton (icon + text) - those guys know how to manage SnackBars

@VaiTon
Copy link
Member

VaiTon commented Sep 8, 2022

What about a button on the AppBar?

immagine

Something like this

@teolemon teolemon added the good first issue Good for newcomers label Oct 8, 2022
@prathamsoni11
Copy link
Contributor

can I work on this issue?

@prathamsoni11
Copy link
Contributor

moved the finish button a bit higher. Is that good?

Screenshot_2022-10-24-12-14-55-972_org openfoodfacts scanner

@M123-dev
Copy link
Member

Heyy @prathamsoni11 higher will maybe work on your device but we can't confirm this for every device. I'm also in favor of replacing it with a FloatingActionButton.extended in the Scaffold as monsieurtanuki suggested.

@prathamsoni11
Copy link
Contributor

Heyy @prathamsoni11 higher will maybe work on your device but we can't confirm this for every device. I'm also in favor of replacing it with a FloatingActionButton.extended in the Scaffold as monsieurtanuki suggested.

ok, I will replace it with a floating action button.

@prathamsoni11
Copy link
Contributor

@M123-dev Something like this??

Screenshot_2022-10-25-08-47-28-468_org openfoodfacts scanner

@AshAman999
Copy link
Member

Can you check @prathamsoni11, if the snack bar is still blocking the finish button?

@g123k
Copy link
Collaborator

g123k commented Oct 25, 2022

Neither solutions are good.
You have to shift the content when the Snackbar is visible.

And no, this not a "5 minute fix" label

@M123-dev
Copy link
Member

Lets still do the FAB first, this is a problem which everyone has and the content is just a problem for people with very small devices

@prathamsoni11
Copy link
Contributor

Can you check @prathamsoni11, if the snack bar is still blocking the finish button?

Yes, it is still blocking I tried solving it but can't get the solution.

One suggestion from my side is that:-
lets move finish button to app bar

@prathamsoni11
Copy link
Contributor

Lets still do the FAB first, this is a problem which everyone has and the content is just a problem for people with very small devices

ok, pushing the code with FAB button

@prathamsoni11
Copy link
Contributor

Now there is no more blocking on the finish button 😀

@AshAman999
Copy link
Member

I guess we can close this issue then , feel free to reopen if necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working good first issue Good for newcomers Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. 🎨 UI / UX
Development

No branches or pull requests

7 participants